refactor: QUIC datagram #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qzhuyan
commented
Sep 7, 2023
| {ok, _Len} = OK -> | ||
| receive | ||
| {quic, send_dgram_completed, Conn} -> | ||
| OK | ||
| {quic, dgram_send_state, Conn, #{state := ?QUIC_DATAGRAM_SEND_SENT}} -> |
There was a problem hiding this comment.
these are not nice, we could intro some dgram event mask for caller to skip uninterested events. also intro async_send_dgram.
thalesmg
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor dgram events, this is a breaking change.
Make dgram events follow others event format 4-element tuple.
dgram send state event
Old code only report success of sending but not other progressing states (discard, cancelled, waiting ack ...)
This PR makes it report any progress state so that application could get feedback quickly and react on it quickly.
dgram state event
Old code only reports when it is enabled.
This PR makes it also reports when it is disabled also with max_len for application layer feedback loop.
dgram received data event
use 4 elements tuples format. It looks like a stream data recv event but with connection handle.
Need followups: