fix: check lib isn't closed while getopt global

emqx · Oct 6, 2023 · 1284705 · 1284705
1 parent 56e9e45
commit 1284705
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/c_src/quicer_config.c b/c_src/quicer_config.c
@@ -21,6 +21,7 @@ limitations under the License.
 #include <msquichelper.h>
 
 extern QuicerRegistrationCTX *G_r_ctx;
+extern pthread_mutex_t MsQuicLock;
 
 static ERL_NIF_TERM get_stream_opt(ErlNifEnv *env,
                                    QuicerStreamCTX *s_ctx,
@@ -768,7 +769,14 @@ getopt3(ErlNifEnv *env,
 
   if (IS_SAME_TERM(ATOM_QUIC_GLOBAL, ctx))
     {
-      res = get_global_opt(env, NULL, eopt);
+      pthread_mutex_lock(&MsQuicLock);
+      // Get global option without using any ctx
+      // We are risking using a closed lib
+      if (MsQuic)
+      {
+        res = get_global_opt(env, NULL, eopt);
+      }
+      pthread_mutex_unlock(&MsQuicLock);
     }
   else if (enif_get_resource(env, ctx, ctx_stream_t, &q_ctx))
     {