Handle paths that already have trailing slashes

empress · Dec 17, 2024 · e7477a7 · e7477a7
1 parent 58d951b
commit e7477a7
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/app/locations/trailing-history.js b/app/locations/trailing-history.js
@@ -10,6 +10,8 @@ export default HistoryLocation.extend({
 
 export function formatURL(url) {
   let modifiedURL = new URL(url, 'http://example.com');
-  modifiedURL.pathname += '/';
+  if (!modifiedURL.pathname.endsWith('/')) {
+    modifiedURL.pathname += '/';
+  }
   return `${modifiedURL.pathname}${modifiedURL.search}${modifiedURL.hash}`;
 }
diff --git a/tests/unit/locations/trailing-history-test.js b/tests/unit/locations/trailing-history-test.js
@@ -13,6 +13,10 @@ module('Unit | Locations | trailing history', function (hooks) {
     assert.deepEqual(formatURL('/foo#placeholder'), '/foo/#placeholder');
   });
 
+  test('does not add double slashes', function (assert) {
+    assert.deepEqual(formatURL('/foo/'), '/foo/');
+  });
+
   test('supports query params and anchors', function (assert) {
     assert.deepEqual(
       formatURL('/foo?bar=baz#placeholder'),