fix(history-queries): selected filters now working for legacy history queries saved in storage without them #1333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… queries saved in storage without them EMP-2528
diegopf
requested changes
Oct 19, 2023
.../x-modules/history-queries/store/actions/load-history-queries-from-browser-storage.action.ts
Outdated
Show resolved
Hide resolved
diegopf
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EMP-2568
Motivation and context
Legacy HQ (history queries stored in the local storage before the new
selectedFiltersfeature was created) caused an error because clicking on them resulted in the utilitygroupBybeing called withundefined.Type of change
What is the destination branch of this PR?
MainHow has this been tested?
Check if you have any legacy HQ in the local storage or create one by removing the
selectedFiltersfield from an existing one and the select it.