Create module tests #1303
Merged
Create module tests #1303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(xcontrols): added files for create skeleton Co-authored-by: Ana Fernández Ostio <[email protected]> * fix(xcontrols): rename package + add skeleton Basic Skeleton added to some files that were empty Co-Authored-By: Matías García Gimeno <[email protected]> Co-Authored-By: Ger-28 <[email protected]> --------- Co-authored-by: Ana Fernández Ostio <[email protected]> Co-authored-by: Ana Fernández Ostio <[email protected]> Co-authored-by: Ger-28 <[email protected]>
EMP-2056 --------- Co-authored-by: Matias Garcia <[email protected]> Co-authored-by: Ana Fernández Ostio <[email protected]> Co-authored-by: Matías García Gimeno <[email protected]> Co-authored-by: Ger-28 <[email protected]>
EMP-2056 --------- Co-authored-by: Ana Fernández Ostio <[email protected]> Co-authored-by: Ana Fernández Ostio <[email protected]> Co-authored-by: Ana Fernández Ostio <[email protected]>
EMP-2064 --------- Co-authored-by: Ana Fernández Ostio <[email protected]> Co-authored-by: Ana Fernández Ostio <[email protected]> Co-authored-by: Ana Fernández Ostio <[email protected]>
EMP-2056 --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Matias Garcia <[email protected]> Co-authored-by: Ana Fernández Ostio <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Matías García Gimeno <[email protected]> Co-authored-by: Guillermo Cacheda <[email protected]> Co-authored-by: empathy/x <[email protected]> Co-authored-by: acondal <[email protected]> Co-authored-by: mariorey <[email protected]> Co-authored-by: Gerardo Vázquez <[email protected]> Co-authored-by: lauramargar <[email protected]> Co-authored-by: Ger-28 <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
annacv
changed the base branch from
main
to
feature/EMP-1944-create-config-module-xcontrols
annacv
commented
Sep 26, 2023
| response: unknown | ||
| ): (url: string, params: RequestInit) => Promise<Response> { | ||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars | ||
| return _url => { |
There was a problem hiding this comment.
👀 Signal not included here as it threw an error.
CachedaCodes
suggested changes
Sep 26, 2023
packages/x-components/src/x-modules/experience-controls/store/__tests__/actions.spec.ts
Outdated
Show resolved
Hide resolved
packages/x-components/src/x-modules/experience-controls/store/__tests__/actions.spec.ts
Outdated
Show resolved
Hide resolved
EMP-2048 --------- Co-authored-by: Matías García Gimeno <[email protected]> Co-authored-by: Ger-28 <[email protected]>
…1306) EMP-2136 --------- Co-authored-by: Ger-28 <[email protected]> Co-authored-by: Guillermo <[email protected]>
…te-endpoint-adapter # Conflicts: # packages/x-types/package.json # pnpm-lock.yaml
…dapter definition
annacv
changed the base branch from
feature/EMP-1944-create-config-module-xcontrols
to
main
CachedaCodes
suggested changes
Oct 9, 2023
packages/x-components/src/__stubs__/experience-controls-subs.factory.ts
Outdated
Show resolved
Hide resolved
...omponents/src/x-modules/experience-controls/components/__tests__/experience-controls.spec.ts
Outdated
Show resolved
Hide resolved
packages/x-components/src/x-modules/experience-controls/store/__tests__/actions.spec.ts
Outdated
Show resolved
Hide resolved
packages/x-components/src/x-modules/experience-controls/store/__tests__/actions.spec.ts
Show resolved
Hide resolved
packages/x-components/src/x-modules/experience-controls/store/__tests__/actions.spec.ts
Outdated
Show resolved
Hide resolved
packages/x-components/src/x-modules/experience-controls/store/types.ts
Outdated
Show resolved
Hide resolved
…__tests__/actions.spec.ts Co-authored-by: Guillermo Cacheda <[email protected]>
…types.ts Co-authored-by: Guillermo Cacheda <[email protected]>
…__tests__/actions.spec.ts Co-authored-by: Guillermo Cacheda <[email protected]>
CachedaCodes
suggested changes
Oct 10, 2023
packages/x-components/src/x-modules/experience-controls/store/__tests__/utils.ts
Outdated
Show resolved
Hide resolved
packages/x-components/src/x-modules/experience-controls/store/__tests__/mutations.spec.ts
Outdated
Show resolved
Hide resolved
packages/x-components/src/x-modules/experience-controls/store/__tests__/getters.spec.ts
Show resolved
Hide resolved
…__tests__/getters.spec.ts Co-authored-by: Guillermo Cacheda <[email protected]>
…__tests__/utils.ts Co-authored-by: Guillermo Cacheda <[email protected]>
CachedaCodes
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EMP-2182