feat: injector utility for the archetype and build config to override the one in X #1258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annacv
reviewed
Aug 3, 2023
| @@ -104,6 +104,7 @@ export const rollupConfig = createRollupOptions({ | |||
| })(); | |||
| const useBrowserInjector = | |||
| (typeof STRIP_SSR_INJECTOR !== 'undefined' && STRIP_SSR_INJECTOR) || isBrowser; | |||
| console.log('${normalizePath(id)}',{source:${varname}}) | |||
There was a problem hiding this comment.
👀 console.log should be there?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EMP-1613
Motivation and context
We needed to encapsulate the styles in the x-archetype overlay from the clients' page, so we needed a way to tell to the styles where they should be injected (by default they're injected at the head of the page).
The injector in this PR does that, along with the rollup config (the implementation would only work on live envs)
Type of change
What is the destination branch of this PR?
MainHow has this been tested?
Run
buildon thex-archetype-utilspackage and the import the build in thex-archetypedependency.Follow this draft in local to see it running:
empathyco/x-archetype#308