Skip to content

Commit

Permalink
Merge pull request #70 from empathyco/feat/alerts
Browse files Browse the repository at this point in the history
fix: review kafka alerts
  • Loading branch information
jmsantorum authored Jul 23, 2024
2 parents 2bc2759 + 60485a6 commit dd53f18
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion charts/motive-service/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@ description: A Helm chart for Kubernetes

type: application

version: 2.1.2
version: 2.1.3

appVersion: "1.0.0"
2 changes: 1 addition & 1 deletion charts/motive-service/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# motive-service

![Version: 2.1.2](https://img.shields.io/badge/Version-2.1.2-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 1.0.0](https://img.shields.io/badge/AppVersion-1.0.0-informational?style=flat-square)
![Version: 2.1.3](https://img.shields.io/badge/Version-2.1.3-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 1.0.0](https://img.shields.io/badge/AppVersion-1.0.0-informational?style=flat-square)

A Helm chart for Kubernetes

Expand Down
4 changes: 2 additions & 2 deletions charts/motive-service/templates/prometheus-rule-alerting.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ spec:
expr: (kafka:topic:messages:in{topic="{{ . }}"} - kafka:topic:messages:in{topic="{{ . }}"} offset 5m) > 0
for: 0m
labels:
severity: critical
severity: warning
skip_resolved: 'true'
{{- with $.Values.metrics.prometheusRule.defaultAlerts.team }}
team: {{ . | quote }}
Expand All @@ -94,7 +94,7 @@ spec:
expr: sum(kafka_consumergroup_lag{namespace="{{ $.Values.metrics.prometheusRule.defaultAlerts.kafka.lag.namespace | required "namespace is required" }}", consumergroup="{{ .consumerGroup | default $.Values.metrics.prometheusRule.defaultAlerts.kafka.lag.consumerGroup | required "consumerGroup is required." }}", topic="{{ .topic | required "topic is required" }}"}) > {{ .threshold | required "threshold is required" }}
for: {{ .for | default "10s" }}
labels:
severity: critical
severity: warning
{{- with $.Values.metrics.prometheusRule.defaultAlerts.team }}
team: {{ . | quote }}
{{- end }}
Expand Down

0 comments on commit dd53f18

Please sign in to comment.