Merge pull request #74 from empathyco/fix/motive-service

fix: strategy does not allow to set Recreate
empathyco · Sep 25, 2024 · 0d48a9c · 0d48a9c
2 parents 2d0cfe1 + fc36506
commit 0d48a9c
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 4 deletions.
diff --git a/charts/motive-service/Chart.yaml b/charts/motive-service/Chart.yaml
@@ -4,6 +4,6 @@ description: A Helm chart for Kubernetes
 
 type: application
 
-version: 2.2.0
+version: 2.2.1
 
 appVersion: "1.0.0"
diff --git a/charts/motive-service/README.md b/charts/motive-service/README.md
@@ -1,6 +1,6 @@
 # motive-service
 
-![Version: 2.2.0](https://img.shields.io/badge/Version-2.2.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 1.0.0](https://img.shields.io/badge/AppVersion-1.0.0-informational?style=flat-square)
+![Version: 2.2.1](https://img.shields.io/badge/Version-2.2.1-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 1.0.0](https://img.shields.io/badge/AppVersion-1.0.0-informational?style=flat-square)
 
 A Helm chart for Kubernetes
 

diff --git a/charts/motive-service/templates/deployment.yaml b/charts/motive-service/templates/deployment.yaml
@@ -25,7 +25,12 @@ spec:
       {{- include "motive-service.serviceSelectorLabels" . | nindent 6 }}
   {{- with .Values.service.updateStrategy }}
   strategy:
-    {{- toYaml . | nindent 4 }}
+    type: {{ .type }}
+    {{- if .type | eq "RollingUpdate" }}
+    rollingUpdate:
+      maxSurge: {{ .rollingUpdate.maxSurge | default "25%" }}
+      maxUnavailable: {{ .rollingUpdate.maxUnavailable | default "25%" }}
+    {{- end }}
   {{- end }}
   template:
     metadata:

diff --git a/charts/motive-service/values.yaml b/charts/motive-service/values.yaml
@@ -87,10 +87,10 @@ service:
 
   # -- Specifies the strategy used to replace old Pods by new ones
   updateStrategy:
+    type: RollingUpdate
     rollingUpdate:
       maxSurge: 25%
       maxUnavailable: 25%
-    type: RollingUpdate
 
   # -- Configurable annotations applied to all pods
   podAnnotations: {}