[FIX] Keyban now correctly checks the master key validity #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Florimond
force-pushed
the
fix_keyban
branch
4 times, most recently
from
3078395
to
8264a05
Compare
Keyban just didn't work. There was a strange channel check while all that was required was to check the validity of the master key. See straighforward code change, for more info. Among other todos to discuss with @kelindar: Can a master key expires?
Florimond
changed the title
kelindar
approved these changes
Sep 2, 2024
Florimond
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keyban just didn't work. There was a strange channel check while all that was required was to check the validity of the master key. See straighforward code change, for more info.