-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable IME support on Linux #5198
base: master
Are you sure you want to change the base?
Conversation
This reverts commit 15d3d43.
It means different things on X11 and Wayland, and causes us to assume IME is active when it isn't, causing the backspace and arrow keys to be disabled.
db250de
to
a293206
Compare
Preview available at https://egui-pr-preview.github.io/pr/5198-fix-linux-ime |
@rustbasic @crumblingstatue can you test this? I've tested with Fedora 40/Gnome 46 with both the regular (Wayland) session and the XOrg session, with the compose key, the Unicode input (Ctrl+Shift+U) and the Chinese (Intelligent Pinyin) input source. Everything seems to work, and the backspace and arrow keys work on both as well. |
I can't test IME, because fcitx (& pals) somehow break my X11 setup (don't ask me how), but I can confirm that backspace and arrow keys work. |
Dear My opinion is,
|
Is there anyone who can test this? I mean, it seems fine to me, but I'm not Chinese so I don't know. #5182 looks like it would require a major release? It's adding fields to structs, so I guess that's a breaking change. But if we can get the IME to work correctly on all platforms, maybe it won't be needed? And egui-winit already has an egui/crates/egui-winit/src/lib.rs Lines 844 to 849 in ce744e6
|
Reverts #5188 and adds a different fix to restore IME on Linux without breaking the backspace and arrow keys.