Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix touch-and-hold to open context menu #4249

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

emilk
Copy link
Owner

@emilk emilk commented Mar 27, 2024

This was broken in cases where the ui wasn't waking up, i.e. when nothing else was happening.

This was broken in cases where the ui wasn't waking up, i.e. when
nothing else was happening.
@emilk emilk added bug Something is broken egui labels Mar 27, 2024
@emilk emilk merged commit 58a2788 into master Mar 27, 2024
37 checks passed
@emilk emilk deleted the emilk/fix-context-menu-on-touch-and-hold branch March 27, 2024 15:39
@emilk emilk added this to the Next Patch Release milestone Mar 28, 2024
emilk added a commit that referenced this pull request Mar 29, 2024
This was broken in cases where the ui wasn't waking up, i.e. when
nothing else was happening.
@emilk emilk mentioned this pull request Mar 29, 2024
emilk added a commit that referenced this pull request Mar 29, 2024
## egui changelog
### 🐛 Fixed
* Fix visual glitch on the right side of highly rounded rectangles
[#4244](#4244)
* Prevent visual glitch when shadow blur width is very high
[#4245](#4245)
* Fix `InputState::any_touches` and add `InputState::has_touch_screen`
[#4247](#4247)
* Fix `Context::repaint_causes` returning no causes
[#4248](#4248)
* Fix touch-and-hold to open context menu
[#4249](#4249)
* Hide shortcut text on zoom buttons if `zoom_with_keyboard` is false
[#4262](#4262)

### 🔧 Changed
* Don't apply a clip rect to the contents of an `Area` or `Window`
[#4258](#4258)


## eframe changelog
* Web: repaint if the `#hash` in the URL changes
[#4261](#4261)
* Add web support for `zoom_factor`
[#4260](#4260) (thanks
[@justusdieckmann](https://github.com/justusdieckmann)!)

---------

Co-authored-by: Justus Dieckmann <[email protected]>
emilk added a commit to emilk/egui_plot that referenced this pull request Jul 15, 2024
## egui changelog
### 🐛 Fixed
* Fix visual glitch on the right side of highly rounded rectangles
[#4244](emilk/egui#4244)
* Prevent visual glitch when shadow blur width is very high
[#4245](emilk/egui#4245)
* Fix `InputState::any_touches` and add `InputState::has_touch_screen`
[#4247](emilk/egui#4247)
* Fix `Context::repaint_causes` returning no causes
[#4248](emilk/egui#4248)
* Fix touch-and-hold to open context menu
[#4249](emilk/egui#4249)
* Hide shortcut text on zoom buttons if `zoom_with_keyboard` is false
[#4262](emilk/egui#4262)

### 🔧 Changed
* Don't apply a clip rect to the contents of an `Area` or `Window`
[#4258](emilk/egui#4258)


## eframe changelog
* Web: repaint if the `#hash` in the URL changes
[#4261](emilk/egui#4261)
* Add web support for `zoom_factor`
[#4260](emilk/egui#4260) (thanks
[@justusdieckmann](https://github.com/justusdieckmann)!)

---------

Co-authored-by: Justus Dieckmann <[email protected]>
Hasenfellvy added a commit to Hasenfellvy/egui_plot that referenced this pull request Aug 27, 2024
## egui changelog
### 🐛 Fixed
* Fix visual glitch on the right side of highly rounded rectangles
[#4244](emilk/egui#4244)
* Prevent visual glitch when shadow blur width is very high
[#4245](emilk/egui#4245)
* Fix `InputState::any_touches` and add `InputState::has_touch_screen`
[#4247](emilk/egui#4247)
* Fix `Context::repaint_causes` returning no causes
[#4248](emilk/egui#4248)
* Fix touch-and-hold to open context menu
[#4249](emilk/egui#4249)
* Hide shortcut text on zoom buttons if `zoom_with_keyboard` is false
[#4262](emilk/egui#4262)

### 🔧 Changed
* Don't apply a clip rect to the contents of an `Area` or `Window`
[#4258](emilk/egui#4258)


## eframe changelog
* Web: repaint if the `#hash` in the URL changes
[#4261](emilk/egui#4261)
* Add web support for `zoom_factor`
[#4260](emilk/egui#4260) (thanks
[@justusdieckmann](https://github.com/justusdieckmann)!)

---------

Co-authored-by: Justus Dieckmann <[email protected]>
hacknus pushed a commit to hacknus/egui that referenced this pull request Oct 30, 2024
This was broken in cases where the ui wasn't waking up, i.e. when
nothing else was happening.
hacknus pushed a commit to hacknus/egui that referenced this pull request Oct 30, 2024
## egui changelog
### 🐛 Fixed
* Fix visual glitch on the right side of highly rounded rectangles
[emilk#4244](emilk#4244)
* Prevent visual glitch when shadow blur width is very high
[emilk#4245](emilk#4245)
* Fix `InputState::any_touches` and add `InputState::has_touch_screen`
[emilk#4247](emilk#4247)
* Fix `Context::repaint_causes` returning no causes
[emilk#4248](emilk#4248)
* Fix touch-and-hold to open context menu
[emilk#4249](emilk#4249)
* Hide shortcut text on zoom buttons if `zoom_with_keyboard` is false
[emilk#4262](emilk#4262)

### 🔧 Changed
* Don't apply a clip rect to the contents of an `Area` or `Window`
[emilk#4258](emilk#4258)


## eframe changelog
* Web: repaint if the `#hash` in the URL changes
[emilk#4261](emilk#4261)
* Add web support for `zoom_factor`
[emilk#4260](emilk#4260) (thanks
[@justusdieckmann](https://github.com/justusdieckmann)!)

---------

Co-authored-by: Justus Dieckmann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken egui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant