Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump winit to 0.29.7 #3753

Merged
merged 6 commits into from
Jan 2, 2024
Merged

Bump winit to 0.29.7 #3753

merged 6 commits into from
Jan 2, 2024

Conversation

dbuch
Copy link
Contributor

@dbuch dbuch commented Dec 30, 2023

Compiled changelog below:

  • On X11, fix Xft.dpi reload during runtime.

  • On X11, fix window minimize.

  • On Web, fix context menu not being disabled by with_prevent_default(true).

  • On Wayland, fix WindowEvent::Destroyed not being delivered after destroying window.

  • Fix EventLoopExtRunOnDemand::run_on_demand not working for consequent invocation

  • On macOS, remove spurious error logging when handling Fn.

  • On X11, fix an issue where floating point data from the server is

  • misinterpreted during a drag and drop operation.

  • On X11, fix a bug where focusing the window would panic.

  • On macOS, fix refresh_rate_millihertz.

  • On Wayland, disable Client Side Decorations when wl_subcompositor is not supported.

  • On X11, fix Xft.dpi detection from Xresources.

  • On Windows, fix consecutive calls to window.set_fullscreen(Some(Fullscreen::Borderless(None))) resulting in losing previous window state when eventually exiting fullscreen using window.set_fullscreen(None).

  • On Wayland, fix resize being sent on focus change.

  • On Windows, fix set_ime_cursor_area.

Compiled changelog below:

 - On X11, fix Xft.dpi reload during runtime.
 - On X11, fix window minimize.

 - On Web, fix context menu not being disabled by with_prevent_default(true).
 - On Wayland, fix WindowEvent::Destroyed not being delivered after destroying window.
 - Fix EventLoopExtRunOnDemand::run_on_demand not working for consequent invocation

 - On macOS, remove spurious error logging when handling Fn.
 - On X11, fix an issue where floating point data from the server is
 - misinterpreted during a drag and drop operation.
 - On X11, fix a bug where focusing the window would panic.
 - On macOS, fix refresh_rate_millihertz.
 - On Wayland, disable Client Side Decorations when wl_subcompositor is not supported.
 - On X11, fix Xft.dpi detection from Xresources.
 - On Windows, fix consecutive calls to window.set_fullscreen(Some(Fullscreen::Borderless(None))) resulting in losing previous window state when eventually exiting fullscreen using window.set_fullscreen(None).
 - On Wayland, fix resize being sent on focus change.
 - On Windows, fix set_ime_cursor_area.
@emilk emilk added eframe Relates to epi and eframe egui-winit porblems related to winit labels Dec 30, 2023
@dbuch dbuch marked this pull request as draft December 30, 2023 09:58
@dbuch dbuch marked this pull request as ready for review December 30, 2023 16:09
@dbuch
Copy link
Contributor Author

dbuch commented Dec 30, 2023

@emilk I've marked this ready. I might disclose the motivation of this, now that i initially forgot.
I'd like to contribute to some points in #3742 in particular linux issues.
Unfortunately this pr din't immediately fix what I hoped fir. However there are some interesting fixes we might hit down the line. Perhaps its ok to move on from this?

@emilk
Copy link
Owner

emilk commented Dec 31, 2023

I appreciate you wanting to help out with Linux!

I think bumping the winit version for this repository makes sense, i.e. updating Cargo.lock, but by also updating the versions in the Cargo.toml:s you are effectively forcing downstream users to update to. This means for instance that if a bug is found in winit 0.29.7 then users of eframe cannot downgrade to 0.29.6.

Usually we should only set a minimal patch version in a Cargo.toml if we absolutely depend on that version.

Therefore, I suggest reverting the changes to the Cargo.toml files and keep just the changes to Cargo.lock.

(tip: in case you don't know, you can update a dependency in a Cargo.lock file using cargo update -p winit)

@emilk emilk merged commit e2c1d9f into emilk:master Jan 2, 2024
19 checks passed
msparkles added a commit to msparkles/egui that referenced this pull request Jan 2, 2024
@emilk emilk added dependencies Pull requests that update a dependency file exclude from changelog labels Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file eframe Relates to epi and eframe egui-winit porblems related to winit exclude from changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants