Use DefaultAzureCredential for azure storage and discourage connectionString
#195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inthemedium
commented
Apr 22, 2024
inthemedium
commented
Apr 22, 2024
inthemedium
commented
Apr 22, 2024
inthemedium
commented
Apr 22, 2024
| { | ||
| baseUri = pathUri; | ||
| } | ||
| var blobServiceClient = string.IsNullOrWhiteSpace(connectionString) |
There was a problem hiding this comment.
This is the beating heart of this change.
A few comments:
- To use
DefaultAzureCredential, we must pass in a URI to the storage account. There is no constructor with a connection string. - Using shared keys is highly discouraged by all the docs. I can provide links if needed.
- Managed Identities "just work"
- By default,
DefaultAzureCredentialdoes not do interactive authentication. - Much of the
AzureCredentialconfiguration can be accomplished with environmental variables. I didn't come up with a strategy to use a differentAzureCredentialper source. This could be done with some more changes to the config files but I suspect YAGNI :-)
inthemedium
commented
Apr 22, 2024
| { | ||
| throw new ArgumentException("Missing connectionString for azure account."); | ||
| await log.LogAsync(LogLevel.Warning, "connectionString is deprecated for azure account. Use path instead."); |
There was a problem hiding this comment.
I needed to change many files to get a hold of this logger. I can make this a separate PR if needed.
|
TODO, need to run tests and do manual testing. |
inthemedium
changed the title
DefaultAzureCredential for azure storage and deprecate connectionStringDefaultAzureCredential for azure storage and discourage connectionString
|
I'll run the functional tests on the CI and verify that the tests with a connection string are still working. |
|
Full functional tests passed ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
DefaultAzureCredentialfor azure storage and discourage connectionStringDefaultAzureCredential, we must pass in a URI to the storage account. There is no constructor with a connection string.DefaultAzureCredentialdoes not do interactive authentication.AzureCredentialconfiguration can be accomplished with environmental variables. I didn't come up with a strategy to use a differentAzureCredentialper source. This could be done with some more changes to the config files but I suspect YAGNI :-)