Skip to content
This repository has been archived by the owner on Nov 19, 2024. It is now read-only.

Add CI and initial python loader/updater #20

Merged
merged 16 commits into from
Jan 29, 2024
Merged

Conversation

dzervas
Copy link
Contributor

@dzervas dzervas commented Jan 20, 2024

The build action now:

  • Doesn't require a binary ninja license
  • Builds the binaries for all platforms
  • If triggered manually, bumps the plugin's version
  • Updates plugin.json longdescription from readme
  • Creates a tag & release

A plugin.json and init.py were also added, however init assumes that in its path the binaries exist which as I understand it binja doesn't do - it just downloads the source of the plugin from the release

init needs to connect to github, find the latest release and download the correct binary - we can do that later

@emesare
Copy link
Owner

emesare commented Jan 29, 2024

Thank you for taking the time to do this! For an initial loader this looks fine, however in the future it would be best to version with the ABI so that older binary ninja installs don't accidentally download a newer version on an unsupported ABI (and vice-versa).

@emesare emesare merged commit 0ccaac2 into emesare:master Jan 29, 2024
6 of 7 checks passed
@emesare emesare mentioned this pull request Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants