Make mysql work for some special cases (database case, views, foreign keys) #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-p-hutchins
force-pushed
the
uppercase-db-names-in-mysql
branch
from
32f9f83 to
6b8f85d
Compare
eric-p-hutchins
changed the title
|
Hi @hutchiep190, I just reviewed your PR. It's a good improvement to the library. Can you please add some tests to the scenários you are covering so I can integrate quickly? Cheers, Emerson |
|
@emerleite Hi, I was using your package for my tests when I came across Foreign Key Checks. I guess any good mysql db would have foreign key checks enabled. Are you by any chance active on this repo ? Even if you are not, would you mind accepting and merging a PR with the changes ? |
|
Hi @palashjhabak. I just need to checkit agian to see if not breaks anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in MySQL if lower_case_table_names is set to 2 then when your database name has an uppercase character database-cleaner will fail because the
show tablesquery returns using a column ofTables_in_<lowercase DB name>Also, if you have views, it will fail.
Also, if any tables have foreign key constraints, it will fail.
Check the value of lower_case_table_names and if it is 2 then lowercasing the database name when constructing the expected column name seems to fix it.
Exclude views when getting table names to truncate so that it doesn't error on them.
Disable foreign key checks so that it doesn't fail on them