Install CMake package config file #306
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cryptomilk
reviewed
Apr 18, 2024
| target_link_libraries(libfswatch PRIVATE ${EXTRA_LIBS}) | ||
|
|
||
| install(TARGETS libfswatch LIBRARY DESTINATION lib) | ||
| install(TARGETS libfswatch EXPORT libfswatch-export LIBRARY DESTINATION lib) | ||
| install(EXPORT libfswatch-export DESTINATION lib/cmake/libfswatch |
There was a problem hiding this comment.
This should be:
install(EXPORT libfswatch-export DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/libfswatch
As it needs to be installed to /usr/lib64 on 64bit platforms.
I guess that other places need to be adjusted too. You need include(GNUInstallDirs) to get access to the variables.
There was a problem hiding this comment.
Thanks, I'll fix it if @emcrisostomo shows up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR amends the existing CMake install commands to also install a package configuration file.
In the client program the package can be located and used like this:
Resolves #305