Respect MAGICK_HOME on Windows #663
Conversation
|
Can you define "clobbering"? This patch removes |
|
Ah! I've answered my own question. So folks on windows that have coderPath = winreg.QueryValueEx(reg_key, "CoderModulesPath")
filterPath = winreg.QueryValueEx(reg_key, "FilterModulesPath")... assuming we don't need those paths exported for folks not defined |
- Don't read Windows registry if MAGICK_HOME was set, keep the original value of the environment variable. - It now seems to be enough to only add the path to the main DLL to PATH. This is also what the ImageMagick installer does if you ask it to add ImageMagick to PATH.
roelandschoukens
force-pushed
the
rs-winpath
branch
from
5214c14 to
1965b74
Compare
|
OK the problem was it was ignoring MAGICK_HOME, since it was overwriting the variable with a value from the registry. Therefore the patch will make it so it only reads from the registry if that environment variable wasn't set. There’s three basic possibilities on Windows, either we get the library from the path given by MAGICK_HOME, or we get it from the path in the registry, or we find the DLL on the system PATH. I think these three possibilities now work. (I contributed this read from the registry some years ago, so I have to admit I am also the guy who broke that first case back then). I remember adding the other two paths was necessary in the past, but that seems not to be the case anymore — the ImageMagick DLL loads successfully without these extra directories on PATH. btw should I also make an issue for this? |
This avoids clobbering the path given by MAGICK_HOME on Windows if the ImageMagick installer wrote the path to ImageMagick to the registry.