-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional test cases for probing MTU/transact size for various dialects #62
base: master
Are you sure you want to change the base?
Conversation
WiP TODO: relocate the write/read tests
move TreeConnectWithDialect into pike.test package init
allow assert_error to take an arbitrary number of ntstatus to check against
add dialect gates for dialect specific tests use new assert_error to assert on multiple status given differing windows behavior fix pep8
flags=0, | ||
file_index=0, | ||
file_name='{0}*'.format(self.filename_prefix), | ||
output_buffer_length=self.payload_size) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we be using max_trans_size here rather than payload_size? (Isn't the goal here to test that we can do a full max_trans_size transfer?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well windows 10 / windows server 2016 return 8mb for max_trans_size, but will still fail the request if the client asks for a buffer larger than 64k, so i'm not really sure why those servers are returning such a large max_trans_size. any ideas would be welcome
Log of running the new tests against onefs 8.1.1, onefs staging 008, windows 7, and windows 2016
https://gist.github.com/isi-mfurer/5f6d30c25a822060e48b04e0e1a1e197