Add lang attribute and use app title in index.html

embroider-build · Jan 24, 2025 · ef44816 · ef44816
1 parent 0b28b0d
commit ef44816
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/files-override/shared/index.html b/files-override/shared/index.html
@@ -1,8 +1,8 @@
 <!DOCTYPE html>
-<html>
+<html<% if(lang) { %> lang="<%= lang %>"<% } %>>
   <head>
     <meta charset="utf-8">
-    <title>AppTemplate</title>
+    <title><%= namespace %></title>
     <meta name="description" content="">
     <meta name="viewport" content="width=device-width, initial-scale=1">
 

diff --git a/files-override/shared/tests/index.html b/files-override/shared/tests/index.html
@@ -2,7 +2,7 @@
 <html>
   <head>
     <meta charset="utf-8" />
-    <title>AppTemplate Tests</title>
+    <title><%= namespace %> Tests</title>
     <meta name="description" content="" />
     <meta name="viewport" content="width=device-width, initial-scale=1" />
 

diff --git a/index.js b/index.js
@@ -226,23 +226,25 @@ module.exports = {
 
     // there doesn't seem to be a way to tell ember-cli to not prompt to override files that were added in the beforeInstall
     // so I'm just copying a few over at this stage
+    const localsFromAppBlueprint = this.locals(options);
+
     copyWithTemplate(
       join(__dirname, 'files-override/shared'),
       options.target,
-      options,
+      localsFromAppBlueprint,
     );
 
     if (options.typescript) {
       copyWithTemplate(
         join(__dirname, 'files-override/ts'),
         options.target,
-        options,
+        localsFromAppBlueprint,
       );
     } else {
       copyWithTemplate(
         join(__dirname, 'files-override/js'),
         options.target,
-        options,
+        localsFromAppBlueprint,
       );
     }