Remove escapeExpression from @ember/template
#20627
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If it was private, shouldn't need to be in the RFC, I'd think |
|
May have been private but |
people using private apis should be used to what happens? 😅 🙃 idk, what's the process here? do we need a deprecation in this case? |
|
Do they know it is private if it is hanging out on If it is truly private, we need an intimate API deprecation (1 LTS cycle), but if it is public, we need an RFC + full deprecation. |
|
I know |
anandfresh
reviewed
Jul 24, 2024
| @@ -456,7 +456,7 @@ export { | |||
| type FunctionBasedHelper, | |||
| type FunctionBasedHelperInstance, | |||
| } from './lib/helper'; | |||
| export { SafeString, escapeExpression, htmlSafe, isHTMLSafe } from './lib/utils/string'; | |||
| export { SafeString, htmlSafe, isHTMLSafe } from './lib/utils/string'; | |||
Co-Authored-By: @chriskrycho
NullVoxPopuli
force-pushed
the
remove-escapeExpression
branch
from
21f9465
to
b46fd5f
Compare
|
I've now rebased this PR, as I forgot about it 😅 |
|
Some test failures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-By: @chriskrycho
Rebase of: #20360
This also gets a mention here: emberjs/rfcs#1003 😅 (for migration docs)