TransitionAborted on a visit()

[spencer516]

We ran into this issue where an aborted transition (which was the behavior we expected) was causing the visit() helper to reject failing our test prematurely.

I don't think this was the case before when writing Acceptance Tests before (it may just be the nature of awaiting promises now); but this also feels unexpected or broken.

I'm not sure of the implications of this fix to suppress the error if it's message is TransitionAborted.

Are there times when we would want that promise to reject when a transition aborts? Should this be configurable instead?

Something like:

visit('/home', { ignoreAbortedTransitions: true });

[simonihmig]

I think you need to run prettier on your changes, to make Travis happy! :)

[simonihmig]

I might miss something obvious, but why is the current URL expected to be /purgatory here, after having visited /?

[Turbo87]

because the transition out of /purgatory is aborted in the willTransition action

[rwjblue]

Sorry for the super long delay here, I'd love to resurrect this PR would you have any time to rebase it?

[spencer516]

@rwjblue — just rebased.

However, this test is now failing for me in Safari :-P Chrome seems fine.

I wasn't able to dig too far into it, but when I disable the Ember 3.4 check in nextTickPromise(), the test is passing again.

Something something RSVP and Native Promises commingling === Unhappy Safari? This type of error feels like there's a new promise getting created somewhere that rejects that ends up not being a part of the promise chain where the catch is added in this PR...maybe?

[rwjblue]

This type of error feels like there's a new promise getting created somewhere that rejects that ends up not being a part of the promise chain where the catch is added in this PR...maybe?

Yes, sounds like exactly what is happening. I'll try to poke at it in the morning, and see if I can fix it up. Generally speaking, the fix here is correct we just need to entangle things properly to absorb the async in the redirect...

[spencer516]

Cool beans. I just made a change to get the 2.4 -> 2.12 scenarios to pass — and rather than aborting the transition, I just re-transition. Test now passes in safari, but that feels like a cheat.

Does transition.abort() create a rejected promise?

For what it's worth, the bubbles up errors test is also failing in Safari for, perhaps, a similar reason.

[rwjblue]

Does transition.abort() create a rejected promise?

Yes, aborting a transition is essentially the same as rejecting a promise.

[samselikoff]

We're running into this, any updates on this or workarounds for now?

[patsy-issa]

Fwiw using redirect() to redirect instead of before/after/model does not cause visit to fail.