Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 07-reusable-components.md #215

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

jmpress
Copy link

@jmpress jmpress commented Oct 11, 2022

No description provided.

@MinThaMie MinThaMie self-requested a review October 12, 2022 07:19
Copy link
Contributor

@MinThaMie MinThaMie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this yourself :)
The linter feels that signup should be sign up.

src/markdown/tutorial/part-1/07-reusable-components.md Outdated Show resolved Hide resolved
@MinThaMie
Copy link
Contributor

@chriskrycho the typescript part of the release goes wrong. It does not seem related to this PR at all, do you know what's up?

@chancancode
Copy link
Collaborator

See #217. This doesn't seem to always happen – as of today I was still able to sign up for a new account, and other than verifying the email address I wasn't asked to put in my credit card. We may also want to point out that the readers can proceed without a valid token if they don't feel like signing up. How about –

  1. You can [sign up](https://www.mapbox.com/signup/) for free and without a credit card. -> You can [sign up here](https://www.mapbox.com/signup/).

  2. Add a Zoey says... to the effect of...

    The sign up process sometimes require a credit card, but the usage for this project is expected to be well within the free tire. Alternatively, you can skip this step and use a placeholder token in the subsequent step (such as "invalid-token"). If you choose to do this, the maps will not render and you will see "broken image" icons in their place, but the tests will pass, allowing you to still follow the rest of the tutorial.

How does that sound?

@chancancode
Copy link
Collaborator

@MinThaMie the typescript stuff does matter – the code for building the tutorial is written in typescript and so that part of the CI pipeline is to compile them into JS (stripping the types) so node can run them.

Looking at the logs:

(The "successful" build was failing for a different reason – an ember data deprecation, there were some discussions about this in the meta channel a while back)

It seems like, we have an indirect dependency on @types/express-serve-static-core and somehow its index.d.ts is tripping up the compiler with syntax errors. We are on a fairly old typescript version so perhaps that is not super surprising, but then we are also using yarn with a lockfile, so I am not sure why that would suddenly fail.

So we will have to either troubleshoot what's going on in the CI server or upgrade TS + some of the deps? Perhaps that's something @chriskrycho can help with indeed (or at least knows someone who could). The code is here and it's around a few hundred lines of vanilla typescript, so it probably won't be so bad?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants