-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 07-reusable-components.md #215
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this yourself :)
The linter feels that signup
should be sign up
.
@chriskrycho the typescript part of the release goes wrong. It does not seem related to this PR at all, do you know what's up? |
See #217. This doesn't seem to always happen – as of today I was still able to sign up for a new account, and other than verifying the email address I wasn't asked to put in my credit card. We may also want to point out that the readers can proceed without a valid token if they don't feel like signing up. How about –
How does that sound? |
@MinThaMie the typescript stuff does matter – the code for building the tutorial is written in typescript and so that part of the CI pipeline is to compile them into JS (stripping the types) so node can run them. Looking at the logs:
(The "successful" build was failing for a different reason – an ember data deprecation, there were some discussions about this in the meta channel a while back) It seems like, we have an indirect dependency on So we will have to either troubleshoot what's going on in the CI server or upgrade TS + some of the deps? Perhaps that's something @chriskrycho can help with indeed (or at least knows someone who could). The code is here and it's around a few hundred lines of vanilla typescript, so it probably won't be so bad? |
No description provided.