✅ 🔥 Delete "Unit | Service | head data" test file #1980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed with @mansona on 2023-11-27 during the ember-learning team weekly meeting: - testing meta data should be done with an acceptance test, not a unit test - this test does not belong to the guides-source project, but rather to `empress/guidemaker`.
✅ Deploy Preview for ember-guides ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @mansona on 2023-11-27 during the ember-learning team weekly meeting:
empress/guidemaker.Issue empress/guidemaker#96 on
empress/guidemakerlets us remember that we need to write this acceptance test, with inspiration from https://github.com/empress/empress-blog/blob/master/tests/acceptance/meta-test.jsunblocks #1977