Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Before you could not add text to progessbars. With this minor fix you ca... #121

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

toovy
Copy link

@toovy toovy commented May 15, 2014

Use the block helpers of bs-progress and bs-progressbar to create progress bars with custom text.

… can use the block helpers of bs-progress and bs-progressbar to create progress bars with custom text.
@asaf
Copy link
Collaborator

asaf commented May 15, 2014

@toovy Why not just replace the Complete text to a property ?

@toovy
Copy link
Author

toovy commented May 15, 2014

@asaf the span.sr-only is only detected by screen readers afaik. That would not solve the problem. As seen here http://getbootstrap.com/components/#progress you can add text directly under the div.progress-bar. Furthermore the problem is that you might want to add even more dynamic segments to the output. See this example:

{{#unless is_amount_open}}
    {{#bs-progress}}
        {{#bs-progressbar type="success" progress=progress}}
            {{format_fn amount_as_currency}}{{currency}} {{progress}}%
        {{/bs-progressbar}}
    {{/bs-progress}}
{{/unless}}

@asaf
Copy link
Collaborator

asaf commented May 15, 2014

@toovy Fair enough, I am not committing yet because the documentation needs to get updated first,

If you have time then feel free to add this code sample into the docs or I'll do it later,

Thanks!

@toovy
Copy link
Author

toovy commented May 15, 2014

@asaf I've added a small chapter, hope that it is ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants