-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Leaderboard 2.0: added performance x n_parameters plot + more benchmark info #1437
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is beautiful! Nice work. I love the current layout.
I see that there's already an open issue on the formatting. Hope we get a response soon.
That's very beautiful! |
Hey @Samoed thanks! I have been there :D After deliberation I though having the citation up close to the benchmark description makes more sense since it is more visually linked to the specific benchmark, and also fills up a gap that would otherwise be there. I also prefer having the plot first than the table, since it communicates the same information, while being easier to interpret visually. I'm open to changing it if enough people think we should rearrange things. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks amazing!
@Muennighoff @Samoed @isaac-chung @KennethEnevoldsen I would also like to hear your take on whether we should be dark or light theme by default, cause in the case that we want to go dark I can also make the plot with dark background and light text. |
I thought Gradio used the system theme by default, which I think is the better option. If not, I would prefer a dark theme |
Alright, we can stick with the default. It just looks a bit weird to have a light plot against a dark background and vice versa. |
FYI somehow got the error below when trying to start the LB in a space, but maybe just me?
|
hmm strange enough. Maybe some model had model size -1 or None? Can you make an issue on this? @Muennighoff |
Nvm I got this, will fix in next PR |
I added an interactive performance vs. number of parameters plot as the first thing people see when selecting a benchmark. #1396
I also added some info on the benchmarks to the benchmark description as Niklas requested here: #1317
Here's a screenshot:
I also bumped the Gradio version, as I thought it might fix certain things, but I have two burning problems still, for which I opened respective issues in Gradio (gradio-app/gradio#9938, gradio-app/gradio#9937)