Graph with layer #38
Open
Graph with layer #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 29 commits
December 18, 2024 17:53
allnes
reviewed
Apr 15, 2025
| void removeLayer(Layer& lay); | ||
| int getLayers() const; | ||
| int getEdges() const; | ||
| bool empty() const; |
There was a problem hiding this comment.
Suggested change
| bool empty() const; | |
| bool isEmpty() const; |
allnes
reviewed
Apr 15, 2025
| std::vector<int> BFS(int start); | ||
| void setInput(Layer& lay, Tensor<double>& vec); | ||
| void setOutput(Layer& lay, Tensor<double>& vec); | ||
| void inference(); |
There was a problem hiding this comment.
Suggested change
| void inference(); | |
| void run(); |
allnes
reviewed
Apr 15, 2025
| int getEdges() const; | ||
| bool empty() const; | ||
| bool hasPath(Layer& layPrev, Layer& layNext) const; | ||
| std::vector<int> BFS(int start); |
There was a problem hiding this comment.
Suggested change
| std::vector<int> BFS(int start); | |
| std::vector<int> inference(int start); |
allnes
reviewed
Apr 15, 2025
| public: | ||
| Layer() = default; | ||
| virtual ~Layer() = default; | ||
| void setID(int id) { id_ = id; } |
There was a problem hiding this comment.
i think it would be string form with integer ID
allnes
reviewed
Apr 15, 2025
| virtual ~Layer() = default; | ||
| void setID(int id) { id_ = id; } | ||
| int getID() const { return id_; } | ||
| virtual void run(const Tensor<double>& input, Tensor<double>& output) = 0; |
There was a problem hiding this comment.
Suggested change
| virtual void run(const Tensor<double>& input, Tensor<double>& output) = 0; | |
| virtual void exec(const Tensor<double>& input, Tensor<double>& output) = 0; |
allnes
reviewed
Apr 15, 2025
Comment on lines
+20
to
+21
| void addNeighbor(Layer* neighbor); | ||
| void removeNeighbor(Layer* neighbor); |
There was a problem hiding this comment.
is it important? I think its part of graph
allnes
reviewed
Apr 15, 2025
| #include "./layer/layer.h" | ||
| #include "./tensor/tensor.h" | ||
|
|
||
| class Graph { |
There was a problem hiding this comment.
Suggested change
| class Graph { | |
| class Network { |
or Model
allnes
reviewed
Apr 15, 2025
| int id_; | ||
|
|
||
| public: | ||
| Layer() = default; |
There was a problem hiding this comment.
please create constructor with abstract class of attributes, @aobolensk what do you think?
allnes
reviewed
Apr 15, 2025
Comment on lines
+23
to
+24
| void addLayer(Layer& lay); | ||
| void addEdge(Layer& layPrev, Layer& layNext); |
There was a problem hiding this comment.
Suggested change
| void addLayer(Layer& lay); | |
| void addEdge(Layer& layPrev, Layer& layNext); | |
| bool addLayer(Layer& lay, std::vector<LayerID>& InputsLayers, std::vector<LayerID>& OutputLayers); |
bool for check - Layer is added or not
addEdge is redudant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.