Onnx library #15
Open
Onnx library #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aobolensk
requested changes
Dec 22, 2024
Comment on lines
+32
to
+38
| *when you use pip, you need to use **venv** to avoid conflict between package managers (apt and pip)* | ||
|
|
||
| *in source(onnx) directory execute these commands:* | ||
| ``` | ||
| python3 -m venv .venv | ||
| source .venv/bin/activate | ||
| ``` |
There was a problem hiding this comment.
- It is not necessary to be done in onnx directory
- It is better to guide users to run something from the specific directory directly specifying
cd <work-dir>
Comment on lines
+40
to
+42
| >to install pip `sudo apt-get install -y python3-pip` | ||
| > | ||
| >to install venv `sudo apt-get install -y python3-venv` |
There was a problem hiding this comment.
- It is better to move up things that should be done before
- You may mention that as a part of build requirements, like:
Requirements:- Python 3.x (specify minimal required version) with pip and venv (optional)
Co-authored-by: Arseniy Obolenskiy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.