net/udp: Relay full UdpMetadata instead of only remote endpoint in poll_ functions #2790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll_ functions This is a breaking change for users of the poll_ functions. (Some might not notice if they already pass in an IpEndpoint into poll_send_to, or discard that item in poll_recv_from).
chrysn
force-pushed
the
prep-embedded-nal-async-udp
branch
from
55d4378 to
7f1bedc
Compare
chrysn
added a commit
to chrysn-pull-requests/embassy
that referenced
this pull request
Apr 8, 2024
…ll_ functions This is a breaking change for users of the poll_ functions. (Some might not notice if they already pass in an IpEndpoint into poll_send_to, or discard that item in poll_recv_from). Cherry-picked-from: embassy-rs#2790
chrysn
added a commit
to chrysn-pull-requests/embassy
that referenced
this pull request
Apr 12, 2024
…ll_ functions This is a breaking change for users of the poll_ functions. (Some might not notice if they already pass in an IpEndpoint into poll_send_to, or discard that item in poll_recv_from). Cherry-picked-from: embassy-rs#2790
Dirbaio
reviewed
Apr 14, 2024
| &self, | ||
| buf: &mut [u8], | ||
| cx: &mut Context<'_>, | ||
| ) -> Poll<Result<(usize, UdpMetadata), RecvError>> { |
There was a problem hiding this comment.
recv_from and poll_recv_from should return the same. can you change recv_from too?
(the convention is poll_* functions are identical to their non-poll counterpart, except manually polled)
There was a problem hiding this comment.
Done in a fixup; this even makes the total diff smaller. Shall I squash and force-push now or when reviews are done?
…t in poll_ functions
|
The merge of main into the branch (AIU this is the pattern used in this repo) fixed the nightly builds. The builds are fixed by providing a fixup as requested in #2790 (review) also for send_to, so that send_to is now consistent with poll_send_to, and another one that fixes unused import warnings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change for users of the poll_ functions. (Some might not notice if they already pass in an IpEndpoint into poll_send_to, or discard that item in poll_recv_from).
It enables embassy users to utilize enhancements in smoltcp that are hopefully coming up in smoltcp-rs/smoltcp#904. Note that those two do not need to lockstep: We can change this now (without gaining many benefits, just access to the packet ID), and once smoltcp updates, the local address will be available as well.
This is the minimal change from #2519, and enables that to progress more easily -- once this one is in, the larger PR should even be testable without adding too many
[patches.crates-io]to already complex setups.[edit: simplified link]