Misc minor issues (courtesy of Stefan Monnier) #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* typescript-mode.el (typescript--function-face): New function. (typescript--font-lock-keywords-4): Use `font-lock-function-name-face` only for definitions, not calls and not decorators. * typescript-mode-general-tests.el (font-lock/level-four) (font-lock/method-call-with-keyword-name): Adjust to new faces. (font-lock/funargs--method--single-line--with-type): Also test the face of the method definition.
* typescript-mode.el: Activate `lexical-binding`. (typescript--font-lock-keywords-2): Use backquote. Quote face names so as not to rely on obsolete `font-lock-*-face` variables. (typescript--re-search-forward, typescript--re-search-backward): Use `funcall` instead of `eval` to save kittens and be compatible with `lexical-binding`. (typescript--font-lock-keywords-3): Quote face names as above. (typescript--font-lock-keywords-4): Fix "\[\]" to "\\[\\]". Quote face names as above. * .gitignore: Add ELPA-generated files.
josteink
force-pushed
the
feature/various-fixes
branch
from
3e7cc81 to
6f3b8b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lexical-binding.font-lock-*-facevariables.funcallinstead ofevalto save kittens and be compatible withlexical-binding.font-lock-function-call-facefor function calls.