refactor: convert candidates to use single format call #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdarcus
force-pushed
the
single-template
branch
from
08eaf31
to
44e46c7
Compare
bdarcus
force-pushed
the
single-template
branch
from
44e46c7
to
2468839
Compare
bdarcus
changed the title
bdarcus
force-pushed
the
single-template
branch
from
09da273
to
89f4184
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At suggestion here: tmalsburg/helm-bibtex#367 (comment)
May be the only convenient way to address #67.
I'm getting a bit confused between this and #83, other than that idea with this one is to retain two templates, but combine them into a single format-entry call, and add the face to the result after.