Skip to content

Commit

Permalink
Added support for async SerializerMethodField
Browse files Browse the repository at this point in the history
  • Loading branch information
em1208 committed Dec 28, 2024
1 parent 8e67221 commit 808312d
Show file tree
Hide file tree
Showing 2 changed files with 38 additions and 0 deletions.
1 change: 1 addition & 0 deletions adrf/fields.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
from rest_framework.serializers import SerializerMethodField as DRFSerializerMethodField


class SerializerMethodField(DRFSerializerMethodField):
async def ato_representation(self, attribute):
method = getattr(self.parent, self.method_name)
Expand Down
37 changes: 37 additions & 0 deletions tests/test_serializers.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
from rest_framework import serializers
from rest_framework.test import APIRequestFactory

from adrf.fields import SerializerMethodField
from adrf.serializers import ModelSerializer, Serializer

from .models import Order, User
Expand Down Expand Up @@ -254,3 +255,39 @@ async def test_order_serializer_valid(self):
assert await sync_to_async(serializer.is_valid)()
assert await serializer.adata == data
assert serializer.errors == {}


class TestSerializerWithSerializerMethodField(TestCase):
def test_sync_serializer_valid(self):
class SimpleSerializer(Serializer):
username = serializers.CharField()
age = SerializerMethodField()

def get_age(self, obj):
return 1900

data = {
"username": "test",
}
data_with_age = {"age": 1900, **data}
serializer = SimpleSerializer(data=data)
assert serializer.is_valid()
assert serializer.data == data_with_age
assert serializer.errors == {}

async def test_async_serializer_valid(self):
class SimpleAsyncSerializer(Serializer):
username = serializers.CharField()
age = SerializerMethodField()

async def get_age(self, obj):
return 1900

data = {
"username": "test",
}
data_with_age = {"age": 1900, **data}
serializer = SimpleAsyncSerializer(data=data)
assert serializer.is_valid()
assert await serializer.adata == data_with_age
assert serializer.errors == {}

0 comments on commit 808312d

Please sign in to comment.