Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2248 After table row is deleted, propertyListener callback has same … #2249

Merged
merged 6 commits into from
Dec 3, 2024

Conversation

Jerinjk14
Copy link
Contributor

fixes: #2248

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

…as same previousValue and value-fixing

Signed-off-by: Jerin George <[email protected]>
@Jerinjk14 Jerinjk14 requested a review from nmgokhale December 2, 2024 06:21
…as same previousValue and value-fixing-final

Signed-off-by: Jerin George <[email protected]>
…as same previousValue and value-fixing-unit tests

Signed-off-by: Jerin George <[email protected]>
@@ -1099,6 +1099,7 @@ export default class PropertiesController {
if (typeof type !== "undefined") {
data.type = type;
}
console.log(data);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

…as same previousValue and value-fixing-removing log statement

Signed-off-by: Jerin George <[email protected]>
@Jerinjk14 Jerinjk14 requested a review from nmgokhale December 3, 2024 01:52
@nmgokhale nmgokhale merged commit ed34cb0 into elyra-ai:main Dec 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After table row is deleted, propertyListener callback has same previousValue and value
2 participants