-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1438 Accessibility: Tabbing - Keyboard navigation of canvas objects (Part 2) #2241
Conversation
…objects (Part2) Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
aa63b9b
to
5261830
Compare
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
} | ||
} | ||
}) | ||
.on("mouseenter", (d3Event, d) => { | ||
// console.log("Mouseenter in node"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove console.log
s in this file
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
@@ -479,6 +500,11 @@ class CanvasContents extends React.Component { | |||
} | |||
} | |||
|
|||
// Returns true if the target element passed in is outside the canvas div. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment says "outside the canvas" but the function name says "inside"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Signed-off-by: CTomlyn <[email protected]>
Fixes: #1438
Developer's Certificate of Origin 1.1