Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1438 Accessibility: Tabbing - Keyboard navigation of canvas objects (Part 2) #2241

Merged
merged 41 commits into from
Dec 4, 2024

Conversation

tomlyn
Copy link
Member

@tomlyn tomlyn commented Nov 13, 2024

Fixes: #1438

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
@tomlyn tomlyn changed the title Keyboard nav2 #1438 Accessibility: Tabbing - Keyboard navigation of canvas objects (Part 2) Nov 13, 2024
@tomlyn tomlyn self-assigned this Nov 13, 2024
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
@tomlyn tomlyn requested a review from nmgokhale November 20, 2024 16:58
}
}
})
.on("mouseenter", (d3Event, d) => {
// console.log("Mouseenter in node");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove console.logs in this file

Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
@tomlyn tomlyn requested a review from nmgokhale November 28, 2024 05:18
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
Signed-off-by: CTomlyn <[email protected]>
@tomlyn tomlyn requested a review from caritaou December 3, 2024 22:20
@@ -479,6 +500,11 @@ class CanvasContents extends React.Component {
}
}

// Returns true if the target element passed in is outside the canvas div.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment says "outside the canvas" but the function name says "inside"

caritaou
caritaou previously approved these changes Dec 4, 2024
Copy link
Member

@caritaou caritaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Signed-off-by: CTomlyn <[email protected]>
@tomlyn tomlyn requested a review from caritaou December 4, 2024 00:55
@tomlyn tomlyn merged commit 9b07ede into elyra-ai:main Dec 4, 2024
3 checks passed
@tomlyn tomlyn deleted the keyboard_nav2 branch December 4, 2024 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessibility: Tabbing - Keyboard navigation of canvas objects
3 participants