-
Notifications
You must be signed in to change notification settings - Fork 3
Allow configuration for other environments. #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
I realize now this PR will break your deployment if you are using |
Hmm, how about checking |
I have different settings in my Brocfile for the How about something like this: // config/deploy.js
module.exports = {
redisProxyEnvs: ['django'] // defaults to 'development'
}
// index.js
// ...
var supportedEnvs = !!config.redixProxyEnvs ? config.redixProxyEnvs : ['development'];
if (supportedEnvs.indexOf(environment) === -1){
return;
}
// ... |
I'm not necessarily opposed to flagging the envs you want to support, but I also don't understand the issue you are trying to raise above. My Why is it a problem to distinguish redis-proxied envs via |
Sure makes sense. I am referring to the "built" index.html being different. The index.html template is the same. I have four environments:
To get the right urls in each deployment I do the following in my var fingerprintOptions = {
enabled: true,
extensions: ['js', 'css', 'png', 'jpg', 'gif'],
};
if (env === 'production' || env === 'staging') {
fingerprintOptions.prepend = 'https://12345.cloudfront.net/';
} else if (env === 'django') {
fingerprintOptions.prepend = 'http://127.0.0.1:8000/static/';
} else {
fingerprintOptions.enabled = false;
} I am also using
So if ember-cli-redis-proxy is going to use the "development" environment to build my app then I will end up with the wrong urls. |
Okay I get it now. That makes sense. Let me think about this... |
Added support for other environment configurations. I am using ember-cli-mirage in development so needed a new environment to configure for running against my backend's development server.