Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] cannot end a flowchart when a End is Then Activity in If #5899

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
b664160
Update End.cs
iio888 Aug 14, 2024
c8781b4
Update Flowchart.cs
iio888 Aug 14, 2024
489ed12
Create BreakWhileFlowchartWorkflow.cs
iio888 Aug 14, 2024
93c3417
Update BreakTests.cs
iio888 Aug 14, 2024
5eaf2dc
Create EndFlowchartWorkflow.cs
iio888 Aug 14, 2024
62d2345
Create EndTests.cs
iio888 Aug 14, 2024
6dd52ea
Merge branch 'main' into fix-end-flowchart
iio888 Aug 15, 2024
8f853b2
Clean Flowchart.cs
iio888 Aug 15, 2024
36ebf0d
Create EndSignal.cs
iio888 Aug 17, 2024
b461cc1
Send EndSignal in End
iio888 Aug 17, 2024
7d4fd32
Create EndSignalActivityExecutionContextExtensions.cs
iio888 Aug 17, 2024
c599a95
Change BreakSignal to EndSignal
iio888 Aug 17, 2024
7ae703f
Merge branch 'main' into fix-end-flowchart
iio888 Aug 18, 2024
822420e
Merge branch 'main' into fix-end-flowchart
iio888 Aug 19, 2024
c0390c6
Send EndSignal when Break
iio888 Aug 20, 2024
ff003f0
Prevent bubbling when received EndSignal
iio888 Aug 20, 2024
8a8afb2
Merge branch 'main' into fix-end-flowchart
sfmskywalker Aug 30, 2024
09cffa1
Merge branch 'elsa-workflows:main' into fix-end-flowchart
iio888 Sep 5, 2024
7044f86
Remove Sending EndSignal in Break Activity
iio888 Sep 5, 2024
dca229e
Receive BreakSignal in Flowchart
iio888 Sep 5, 2024
184ca1e
Remove StopPropagation in BreakSignal
iio888 Sep 5, 2024
456ad94
Merge branch 'main' into fix-end-flowchart
iio888 Sep 6, 2024
c11ffae
Merge branch 'main' into fix-end-flowchart
iio888 Sep 9, 2024
9d6c4ff
Merge branch 'main' into fix-end-flowchart
sfmskywalker Sep 12, 2024
f0f7c0c
Fix spell error
iio888 Sep 13, 2024
1faec5b
Merge branch 'main' into fix-end-flowchart
iio888 Sep 17, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Clean Flowchart.cs
iio888 authored Aug 15, 2024
commit 8f853b2f6c0e374e5614187348f190df4190770b
Original file line number Diff line number Diff line change
@@ -145,7 +145,8 @@ private async ValueTask OnChildCompletedAsync(ActivityCompletedContext context)
var result = context.Result;

bool isBreaking = flowchartContext.GetIsBreaking();
if (isBreaking) {
if (isBreaking)
{
await flowchartContext.CompleteActivityAsync();
return;
}