Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fantomas and require correct formatting #591

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

LyndonGingerich
Copy link
Contributor

Resolves #434.

This PR is starting as a work in progress so I can see pipeline results; I'm new to GitHub Actions.

@LyndonGingerich
Copy link
Contributor Author

I haven't reviewed all the code changes, but I have imported the requested .editorconfig changes from the previous PR. As far as I am concerned, this is ready to merge.

@LyndonGingerich
Copy link
Contributor Author

We might want to squash merge this PR.

@YkTru
Copy link

YkTru commented Apr 18, 2024

Hi, I want to know: what specifically is "correct formatting"? What will it add to/modify in fantomas?

Thank you

@LyndonGingerich
Copy link
Contributor Author

@YkTru, I don't understand. What do you want to know that is not in the file diff and the .editorconfig?

@marner2
Copy link
Collaborator

marner2 commented Oct 1, 2024

@LyndonGingerich can you rebase this? I'd like to get it in so we don't have to worry about formatting anymore.

@marner2 marner2 self-requested a review October 1, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fantomas code formatter
3 participants