Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chrome extensions (Grammarly in our case) cause runtime errors #182

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Chrome extensions (Grammarly in our case) cause runtime errors #182

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0f2456
fix elm/html#44
jinjor Oct 22, 2019
c774355
Merge pull request #1 from jinjor/fix-extension-bug
erlandsona Jun 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 65 additions & 3 deletions src/Elm/Kernel/VirtualDom.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,7 +434,9 @@ function _VirtualDom_render(vNode, eventNode)

if (tag === __2_TEXT)
{
return _VirtualDom_doc.createTextNode(vNode.__text);
var n = _VirtualDom_doc.createTextNode(vNode.__text);
n.created_by_elm = true;
return n
}

if (tag === __2_TAGGER)
Expand Down Expand Up @@ -469,6 +471,7 @@ function _VirtualDom_render(vNode, eventNode)
var domNode = vNode.__namespace
? _VirtualDom_doc.createElementNS(vNode.__namespace, vNode.__tag)
: _VirtualDom_doc.createElement(vNode.__tag);
domNode.created_by_elm = true;

if (_VirtualDom_divertHrefToApp && vNode.__tag == 'a')
{
Expand Down Expand Up @@ -1328,14 +1331,52 @@ function _VirtualDom_addDomNodesHelp(domNode, vNode, patches, i, low, high, even

var vKids = vNode.__kids;
var childNodes = domNode.childNodes;
for (var j = 0; j < vKids.length; j++)
for (var j = 0, k = 0; j < Math.max(vKids.length, childNodes.length); j++, k++)
{
low++;
var vKid = tag === __2_NODE ? vKids[j] : vKids[j].b;
var nextLow = low + (vKid.__descendantsCount || 0);

// The following 1-4 are added to avoid runtime errors due to browser extensions.
// This logic assumes that insertion and replacement do not occur at the same time.

// 1. if unknown nodes have been inserted, skip them
if(childNodes.length > vKids.length)
{
while(!childNodes[k].created_by_elm)
{
k++
}
}
// 2. if existing node has been removed, restore it from the old vnode
if(childNodes.length < vKids.length)
{
if(childNodes[k])
{
_VirtualDom_applyPatchRedraw(childNodes[k], vKids[j], eventNode)
}
else
{
domNode.appendChild(_VirtualDom_render(vKids[j], eventNode));
}
}
// 3. if existing node has been replaced, restore it from the old vnode
if(childNodes.length === vKids.length)
{
if(!childNodes[k].created_by_elm)
{
_VirtualDom_applyPatchRedraw(childNodes[k], vKids[j], eventNode)
}
}
// 4. final check for some edge cases
if(vKids[j].$ === __2_NODE && (childNodes[k].tagName || "").toLowerCase() !== vKids[j].__tag)
{
_VirtualDom_applyPatchRedraw(childNodes[k], vKids[j], eventNode)
}

if (low <= index && index <= nextLow)
{
i = _VirtualDom_addDomNodesHelp(childNodes[j], vKid, patches, i, low, nextLow, eventNode);
i = _VirtualDom_addDomNodesHelp(childNodes[k], vKid, patches, i, low, nextLow, eventNode);
if (!(patch = patches[i]) || (index = patch.__index) > high)
{
return i;
Expand Down Expand Up @@ -1408,6 +1449,25 @@ function _VirtualDom_applyPatch(domNode, patch)

case __3_REMOVE_LAST:
var data = patch.__data;

// Added to avoid runtime errors due to browser extensions.
if(domNode.childNodes.length !== data.__diff + data.__length)
{
var removed = 0;
var index = domNode.childNodes.length - 1;
while (removed < data.__diff)
{
var childNode = domNode.childNodes[index];
if(childNode.created_by_elm)
{
domNode.removeChild(childNode);
removed++;
}
index--;
}
return domNode;
}

for (var i = 0; i < data.__diff; i++)
{
domNode.removeChild(domNode.childNodes[data.__length]);
Expand Down Expand Up @@ -1525,6 +1585,8 @@ function _VirtualDom_applyPatchReorderEndInsertsHelp(endInserts, patch)

function _VirtualDom_virtualize(node)
{
node.created_by_elm = true;

// TEXT NODES

if (node.nodeType === 3)
Expand Down