Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to GH Actions + elm-tooling and expose subsequencesNonEmpty 🆕 #168

Merged
merged 4 commits into from
Oct 31, 2022

Conversation

kutyel
Copy link
Contributor

@kutyel kutyel commented Oct 21, 2022

This is just a general migration to GH Actions and the latest version of elm-test to make it easier to maintain the library in the future. Also, CI will now be run on PRs! (which is desirable for contributions 😉 ).

This setup is identical to the one for maybe-extra and so I think unifying this for some elm-community packages could be beneficial 💡

Also this uses the latest version of [email protected] 🚀

Please feel free to add the hacktoberfest-accepted label to this PR 😉

@kutyel kutyel changed the title Optimize and expose subsequencesNonEmpty 🆕 Migrate to GH Actions and elm-tooling 🆕 Oct 25, 2022
@kutyel
Copy link
Contributor Author

kutyel commented Oct 25, 2022

To verify that the GH action succeeded, you can check my fork https://github.com/kutyel/list-extra/actions/runs/3320767331/jobs/5487533854

@kutyel kutyel changed the title Migrate to GH Actions and elm-tooling 🆕 Migrate to GH Actions + elm-tooling and expose subsequencesNonEmpty 🆕 Oct 26, 2022
@kutyel kutyel requested a review from Janiczek October 26, 2022 10:03
@Janiczek
Copy link
Contributor

(I see your "requested a review" but I'm not a maintainer :) @Chadtech is)

@kutyel
Copy link
Contributor Author

kutyel commented Oct 26, 2022

@Janiczek @Chadtech also open to discuss if it is valuable to add the package-lock.json file or not, in this case it would be useful for caching (in the GH action 😉 )

@Chadtech
Copy link
Collaborator

Thank you very much! This was much needed! ❤️

@Chadtech Chadtech merged commit 97a44be into elm-community:master Oct 31, 2022
@kutyel kutyel deleted the fix/tail-call-opts branch October 31, 2022 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants