Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix spec for elli:stop/1 #113

Merged
merged 1 commit into from
Jun 29, 2024
Merged

Fix spec for elli:stop/1 #113

merged 1 commit into from
Jun 29, 2024

Conversation

paulo-ferraz-oliveira
Copy link
Contributor

@paulo-ferraz-oliveira paulo-ferraz-oliveira commented Jul 27, 2023 •
edited
Loading

Closes #111.

Depends on the CI file updates from #114, so shall be rebased and updated (if required) after that one.

@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2023 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.40%. Comparing base (05e24b1) to head (bda6af9).
Report is 26 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #113      +/-   ##
==========================================
+ Coverage   76.30%   76.40%   +0.09%     
==========================================
  Files          12       12              
  Lines         764      750      -14     
==========================================
- Hits          583      573      -10     
+ Misses        181      177       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paulo-ferraz-oliveira
Copy link
Contributor Author

paulo-ferraz-oliveira commented Jul 27, 2023 •
edited
Loading

CI failing for OTP 26, and 25. I'll try to replicate locally.

@paulo-ferraz-oliveira
Copy link
Contributor Author

paulo-ferraz-oliveira commented Jul 27, 2023 •
edited
Loading

It's possible the failure for non-OTP 26 is due to #99, since re-executing the tests (in a fork) showed ✅.

@paulo-ferraz-oliveira
Copy link
Contributor Author

paulo-ferraz-oliveira commented Jul 28, 2023 •
edited
Loading

Removed OTP 26 from scope, since there're SSL -related issues to solve. Should be moved to a new PR, I guess...

@paulo-ferraz-oliveira paulo-ferraz-oliveira marked this pull request as draft October 10, 2023 15:20
@paulo-ferraz-oliveira
Copy link
Contributor Author

Moved to draft. These don't need to be reviewed before #114, after which I'll rebase.

@paulo-ferraz-oliveira paulo-ferraz-oliveira marked this pull request as ready for review June 28, 2024 20:50
@paulo-ferraz-oliveira
Copy link
Contributor Author

@tsloughter

@tsloughter tsloughter merged commit 3600345 into elli-lib:main Jun 29, 2024
2 checks passed
@paulo-ferraz-oliveira paulo-ferraz-oliveira deleted the fix/spec branch June 29, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsloughter tsloughter tsloughter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid spec for elli:stop/1
3 participants
@paulo-ferraz-oliveira @codecov-commenter @tsloughter