Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Elixir/Erlang versions in CI #1257

Merged
merged 1 commit into from
Dec 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ jobs:
PLUG_CRYPTO_2_0: "false"

# Latest-supported Elixir/Erlang pair.
- elixir: "1.17"
otp: "27.0"
- elixir: "1.18"
otp: "27.2"
lint: lint
PLUG_CRYPTO_2_0: "true"

Expand Down
15 changes: 10 additions & 5 deletions test/plug/debugger_test.exs
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,8 @@ defmodule Plug.DebuggerTest do

get "/bad_match" do
_ = conn
bad_match(:six, :one)
# Code.eval_quoted/2 to avoid typing violations at compile time.
Code.eval_quoted(quote do: unquote(__MODULE__).bad_match(:six, :one))
end

get "/send_and_wrapped" do
Expand All @@ -77,14 +78,18 @@ defmodule Plug.DebuggerTest do
raise ActionableError
end

defp returns_nil, do: nil
# Code.eval_quoted/2 to avoid typing violations at compile time.
defp returns_nil do
{result, _bindings} = Code.eval_quoted(quote do: nil)
result
end

defp add_csp(conn, _opts),
do: Plug.Conn.put_resp_header(conn, "content-security-policy", "abcdef")

defp bad_match(:one, :two), do: :ok
defp bad_match(:three, :four), do: :ok
defp bad_match(:five, :six), do: :ok
def bad_match(:one, :two), do: :ok
def bad_match(:three, :four), do: :ok
def bad_match(:five, :six), do: :ok
end

defmodule StyledRouter do
Expand Down