Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvement: add redirects config, and documentation explaining it #1952

Merged
merged 11 commits into from
Sep 17, 2024
Merged

improvement: add redirects config, and documentation explaining it #1952

merged 11 commits into from
Sep 17, 2024

Conversation

zachdaniel
Copy link
Contributor

@zachdaniel zachdaniel commented Sep 17, 2024 •
edited
Loading

Proposed solution for #1951

zachdaniel
zachdaniel commented Sep 17, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
josevalim
josevalim reviewed Sep 17, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@zachdaniel @josevalim
Update README.md
3917268 
Co-authored-by: José Valim <[email protected]>
josevalim
josevalim reviewed Sep 17, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@zachdaniel @josevalim
Update README.md
897b7b6 
Co-authored-by: José Valim <[email protected]>
josevalim
josevalim reviewed Sep 17, 2024
View reviewed changes
mix.exs Outdated Show resolved Hide resolved
josevalim
josevalim reviewed Sep 17, 2024
View reviewed changes
README.md Show resolved Hide resolved
@josevalim josevalim merged commit 2c1a895 into elixir-lang:main Sep 17, 2024
5 checks passed
@josevalim
Copy link
Member

💚 💙 💜 💛 ❤️

@josevalim
Copy link
Member

Excellent turn around here, thank you!

@garazdawi
Copy link
Contributor

Excellent feature! I'm a bit late to the party, but would it not be good to add this option to the list of options in https://github.com/elixir-lang/ex_doc/blob/main/lib/mix/tasks/docs.ex? So that we have a common list for all options available?

@josevalim
Copy link
Member

Yes, it would be good indeed. :) @zachdaniel, please let me know if you can do it or if you'd prefer for us to push it.

@zachdaniel
Copy link
Contributor Author

Will add when I'm at a computer 👍👍

@zachdaniel
Copy link
Contributor Author

PR here: https://github.com/elixir-lang/ex_doc/pull/1953/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josevalim josevalim josevalim left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zachdaniel @josevalim @garazdawi