Keep custom flags with the custom_flags_to_keep option
#370
Conversation
Background: While merging translations with `mix gettext.merge` flags get cleared out and replaced with the exception of `fuzzy`, which is kept. This change will allow the `custom_flags_to_keep` flag to add a list of flags to be kept in addition to `fuzzy` which helps prevent information loss if external tools adds their own flags to messages. Fixes elixir-gettext#369
|
It got a little bit awkward to pass on the |
|
@johantell I’m seeing that we don't really have any Gettext-level config related to merging, right? Because if so, we could potentially start with making this a CLI flag for the |
|
@whatyouhide I would prefer it to be a config option rather than a CLI flag, primarily because I've heard from colleagues that they sometimes use the mix alias we have and sometimes not. I somehow see this more as a global-level option than something that would tend to change between runs, whereas the only CLI options related to merging (from what I can understand) are I could see how merging the configured options with the CLI input into a single struct could make the number of arguments go down, but I would also assume that to be a significant undertaking only to have fewer arguments passed around :P. |
|
Thank you @johantell! ❤️ |
| else | ||
| new.flags | ||
| end | ||
| @default_flags_to_keep ["elixir-format", "fuzzy"] |
There was a problem hiding this comment.
We should only have a special rule for the fuzzy flag. The format flag is depending on the enabled interpolation module and might differ from elixir-format.
There was a problem hiding this comment.
Too late for merge, please still consider it @whatyouhide 😊
There was a problem hiding this comment.
@maennchen ah that's a great call out. PR? 😬
There was a problem hiding this comment.
@whatyouhide I recently had surgery and am on a lot of pain meds. I think it would be better if you could do this without me…
There was a problem hiding this comment.
@maennchen ah, sure! Good luck with recovery then 🤗
|
@whatyouhide Do you think there any chance we'll see a release that includes these changes anytime soon, or would you prefer to wait a bit to include other things in the next release? 👼 |
|
@johantell I don't have cycles to spend on this right now, so for now no release. I can try to do it by end of week, but we'll see how things look like. Sorry! |
|
@whatyouhide Alright, no problem. I'll lock on the latest commit until you've found time. Thanks for taking the time to answer, and let me know if there is anything I can do to help out :) |
|
@johantell ok I snuck this in, 0.23.0 is out! 👍 |
|
@whatyouhide You're my hero! ❤️ 💛 💚 💙 |
Background:
While merging translations with
mix gettext.mergeflags get cleared out and replaced with the exception offuzzy, which is kept.This change will allow the
custom_flags_to_keepflag to add a list of flags to be kept in addition tofuzzywhich helps prevent information loss if external tools adds their own flags to messages.Fixes #369