Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make region and bucket as optional and always set the endpoint #2

Merged
merged 6 commits into from
Aug 22, 2023

Commits on Aug 17, 2023

  1. Configuration menu
    Copy the full SHA
    90dd8f4 View commit details
    Browse the repository at this point in the history
  2. Parse config from bucket URL

    philss committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    eb4f39f View commit details
    Browse the repository at this point in the history
  3. Revert "Parse config from bucket URL"

    This reverts commit eb4f39f.
    philss committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    6b5ecd2 View commit details
    Browse the repository at this point in the history
  4. Make region and bucket as optionals, and set endpoint

    These are changes necessary to support the usage when only the bucket
    url is known.
    philss committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    e713ed5 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2023

  1. Better document the endpoint field for S3

    Also make that attribute required in the typespecs.
    philss committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    9154e1d View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2023

  1. Fix parsing of s3:// URL to consider empty bucket

    This is going to treat the endpoint differently depending on
    bucket name. It is also going to make `:bucket` nil if we can
    build a virtual-host style endpoint.
    
    The rules are more or less the following:
    
    * Endpoint is given
      * And bucket is an empty string (s3:///path): keep bucket nil
      * Otherwise keep both endpoint and bucket in config
    * Endpoint is nil
      * Bucket has dots: keep the endpoint _without_ the bucket, fill in bucket field
      * Bucket does not have dots: keep the endpoint with bucket, bucket is nil
    philss committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    7c0b303 View commit details
    Browse the repository at this point in the history