Fix overwrite of dtypes for DF.load_csv/2
#955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the `with_schema` function does not correctly because expects to receive all column names, and with the correct order. We are passing a map to the backend, and then we transform that to a list before calling the Rust code. So the schema could be out-of-order. We are now using `with_schema_overwrite` for both `load_csv` and `from_csv`. Closes #953
josevalim
reviewed
Aug 1, 2024
native/explorer/src/dataframe/io.rs
Outdated
| let read_options = if dtypes.is_empty() { | ||
| CsvReadOptions::default() | ||
| } else { | ||
| CsvReadOptions::default().with_schema_overwrite(Some(schema_from_dtypes_pairs(dtypes)?)) |
There was a problem hiding this comment.
Maybe instead of a conditional, we could have schema_from_dtypes_pairs return Some/None accordingly, and we always call with_schema_overwrite?
There was a problem hiding this comment.
Good call! I changed in 8460170
josevalim
approved these changes
Aug 1, 2024
josevalim
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the
with_schemafunction does not work correctly because Polars expects to receive all column names, and with the correct order. We are passing a map to the backend, and then we transform that to a list before calling the Rust code. So the schema could be out-of-order.We are now using
with_schema_overwritefor bothload_csvandfrom_csv.Closes #953