-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: parse dates, times, and timestamps #30
Conversation
While working on parsing times, I ran into this Go panic
|
Hi @superhawk610! I believe the bug you are seeing is this one: apache/arrow-adbc#1021 You can try using v0.7.0-rc and see if it address it. https://github.com/apache/arrow-adbc/releases/tag/apache-arrow-adbc-0.7.0 I will add a guide on updating ADBC, but it should be:
Thanks for the PR and let me know if there is anything else we can help with. :) |
That fixed it! Should I check in the driver version upgrade with this PR? |
8465b81
to
2bb5b96
Compare
2bb5b96
to
8a3a5b3
Compare
@superhawk610 I will do it in another PR. That's because if it is an external contribution, I need to review all code. :) I will ping you in the PR for double checking. |
Btw, can you add tests using sqlite or PG? Or should I push them after merging? |
I can add tests early next week! |
💚 💙 💜 💛 ❤️ |
This PR adds support for some Arrow temporal formats - dates, times, and timestamps. I'm primarily using ADBC with Snowflake, which doesn't support the full set of Arrow temporal formats (no timestamps with timezones, durations, or intervals).
These three formats can be tested using the following query: