Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Policy maker role text #1338

Merged
merged 1 commit into from
Aug 9, 2023
Merged

New Policy maker role text #1338

merged 1 commit into from
Aug 9, 2023

Conversation

wittigue
Copy link
Collaborator

new Policy maker role text based on Google document from contentathon #1276

new Policy maker role text based on document from contentathon
#1276
@wittigue wittigue added the contentathon Contentathon related issues and PRs label Jul 14, 2023
Copy link
Collaborator

@floradanna floradanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General feedback:

  1. Revision of the list of links to training material: e.g. lessons about Data Carpentry might not be super relevant for DS policy officer. Maybe the list could be more focus on the policy.
  2. About the paragraph "RDMkit pages", I was wondering if it was really necessary since almost all those page are listed as "related pages" from the metadata of the md page.

@MijkeJetten
Copy link
Contributor

For me the page is good to go. One thing: shouldn't we update the contributors list as well to (alone) the Ghent Your Role authors?

@bedroesb
Copy link
Member

bedroesb commented Aug 3, 2023

This is a fair question @elixir-europe/rdmkit-editors any opinions?

@MijkeJetten
Copy link
Contributor

@bedroesb this is a fully new page, so any other contributors would be weird anyway. For the researcher your role page it might be somewhat different as there was a page before, but the updates are major (hardly any original text left) so I would go for the new contributors only for both pages

@floradanna
Copy link
Collaborator

@MijkeJetten I am not sure it would be fair. I would keep the names of people that contributed to the previous pages anyway. The new pages are anyway written based on what was there before.

@MijkeJetten
Copy link
Contributor

Fine with everything, but we do need the add the new people if they are missing - do we then go for same contributor list for all your role pages, as it was a joint effort in the end.

@bedroesb bedroesb added the topic/YourRole Personas specific issue or PR label Aug 4, 2023
@bedroesb bedroesb mentioned this pull request Aug 7, 2023
@bedroesb bedroesb changed the base branch from master to role-restructure August 9, 2023 13:29
@bedroesb
Copy link
Member

bedroesb commented Aug 9, 2023

I will move it to the dev branch for these changes!

@bedroesb bedroesb merged commit 05c75cf into role-restructure Aug 9, 2023
@bedroesb bedroesb deleted the wittigue-patch-1 branch August 9, 2023 13:36
bedroesb added a commit that referenced this pull request Aug 9, 2023
* New Data Steward page (#1346)

* New PI page for Your role

* New Data Steward page plus tweaks to other role pages

* Removing the PI page to clean PR

* Update data_steward.md

changed wrong Infrastructure DS description

---------

Co-authored-by: wittigue <[email protected]>

* New Policy maker role text (#1338)

new Policy maker role text based on document from contentathon
#1276

* New role page for Research Software Engineer (#1349)

* New role page for RSE

* Update research_software_engineer.md

changed two urls

---------

Co-authored-by: wittigue <[email protected]>

* replace legacy links

* update sidebar

* add redirects

* Removed repeated contributors

* no https://rdmkit.elixir-europe.org/ in url

---------

Co-authored-by: Martin Cook <[email protected]>
Co-authored-by: wittigue <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contentathon Contentathon related issues and PRs topic/YourRole Personas specific issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants