Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibiity to change the mongodb host #51

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

lvarin
Copy link
Contributor

@lvarin lvarin commented Jul 15, 2024

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have not reduced the existing code coverage
  • I have added docstrings following the Python style guidelines of this project to all new modules, classes, methods and functions are documented with docstrings following; I have updated any previously existing docstrings, if applicable
  • I have updated any sections of the app's documentation that are affected by the proposed changes, if applicable

Summary by Sourcery

This pull request introduces the ability to configure the MongoDB host through the MONGO_HOST environment variable, with a default value of 'mongodb' if not specified. The deployment template has been updated to support this new configuration.

  • New Features:
    • Added the ability to configure the MongoDB host via the MONGO_HOST environment variable.
  • Enhancements:
    • Default MongoDB host is set to 'mongodb' if MONGO_HOST is not provided.
  • Deployment:
    • Updated deployment template to include MONGO_HOST environment variable configuration.

Copy link

sourcery-ai bot commented Jul 15, 2024

Reviewer's Guide by Sourcery

This pull request introduces the ability to change the MongoDB host by adding a new environment variable MONGO_HOST. The changes are implemented by modifying the update-config-map.sh script and the cloud-registry-configmap-job.yaml deployment template to include and utilize this new variable.

File-Level Changes

Files Changes
update-config-map.sh
deployment/templates/cloud-registry-configmap-job.yaml
Introduced the MONGO_HOST environment variable to allow dynamic configuration of the MongoDB host.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

@lvarin lvarin requested a review from jemaltahir July 15, 2024 13:03
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lvarin - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 2 issues found
  • 🟡 Security: 1 issue found
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

update-config-map.sh Show resolved Hide resolved
update-config-map.sh Show resolved Hide resolved
Copy link

@jemaltahir jemaltahir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jemaltahir jemaltahir merged commit 86157c6 into dev Jul 15, 2024
4 checks passed
@jemaltahir jemaltahir deleted the allow-mongodb-host-config branch July 15, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants