-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: set taskmaster manifest from FOCA config #206
Conversation
Reviewer's Guide by SourceryThis pull request configures the taskmaster manifest from the FOCA configuration. It introduces new utility functions to handle custom configurations and creates a taskmaster template based on these configurations. The changes primarily affect the File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @JaeAeich - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟡 Security: 1 issue found
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #206 +/- ##
=======================================
Coverage 98.21% 98.21%
=======================================
Files 8 8
Lines 561 561
=======================================
Hits 551 551
Misses 10 10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you look into the hard coded fields. Otherwise the code looks great :)
@jemaltahir The constants are coming from here, and they aren't used anywhere else, do you think I should still change it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Ideally, I would have liked to see some abstraction over the FTP stuff, but let's move forward now and figure that out some other time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clicked the wrong button, apologies. Approved now.
Summary by Sourcery
Configure the taskmaster manifest from FOCA configuration by adding new methods to retrieve custom configurations and taskmaster templates. Enhance the configuration model to include taskmaster-specific properties, enabling more flexible and dynamic taskmaster setup.
New Features:
Enhancements: