build: clean up deps #180
build: clean up deps #180
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
We have skipped reviewing this pull request. We don't currently review these file types ['.lock', '.toml'] - Let us know if you'd like us to change this.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #180 +/- ##
=======================================
Coverage 98.21% 98.21%
=======================================
Files 8 8
Lines 559 559
=======================================
Hits 549 549
Misses 10 10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Looks good to me. Just two small issues:
- Can you please sort the deps in alphanumerical order in each section? It's easy to miss a dependency that's already in there.
- I think you can remove
kubernetesfrom the test deps, as it's already in the app dependencies (as I think you already mentioned you would in your PR description).
|
Also please note that |
Description
Useless dependency group
dev, this would just make it harder to maintain versions.Note: Removed
k8sfrom test deps group, it should be obv that to test,teskshould be installed :)