Skip to content

Commit

Permalink
remove hook but leave CI to lint non code files
Browse files Browse the repository at this point in the history
  • Loading branch information
JaeAeich committed May 24, 2024
1 parent 76074f6 commit 44d037c
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 138 deletions.
15 changes: 7 additions & 8 deletions .github/workflows/validation_pr.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -47,19 +47,18 @@ jobs:
- name: Fail or succeed job if any files with merge conflict markers
run: exit $(git grep "<<<<<<<" ":(exclude).github/" | wc --lines)

pre-commit:
name: Pre-commit checks
general_checks:
name: General checks
runs-on: ubuntu-latest
steps:
- name: Check out repository
uses: actions/checkout@v4
- name: Set up environment
uses: ./.github/actions/setup/poetry
- uses: 'actions/setup-python@v5'
id: setup-python
with:
os: ${{ job.os }}
python-version: '3.11'
poetry-install-options: "--only=misc"
poetry-export-options: "--only=misc"
- name: Install pre-commit
run: pip install pre-commit
- name: Run pre-commit checks
run: poetry run pre-commit run --all-files
run: pre-commit run --all-files
...
6 changes: 0 additions & 6 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,6 @@ repos:
- id: mixed-line-ending
args: [--fix=auto]
- id: trailing-whitespace
- repo: https://github.com/astral-sh/ruff-pre-commit
rev: v0.4.5
hooks:
- id: ruff
- id: ruff-format
args: [--check]
- repo: https://github.com/executablebooks/mdformat
rev: 0.7.17
hooks:
Expand Down
122 changes: 1 addition & 121 deletions poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,6 @@ typos = "^1.21.0"
ruff = "^0.4.4"
typos = "^1.21.0"

[tool.poetry.group.misc.dependencies]
pre-commit = "^3.7.1"

[tool.poetry.group.security.dependencies]
bandit = "^1.7.8"
safety = "^3.2.0"
Expand Down

0 comments on commit 44d037c

Please sign in to comment.